Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer #19647

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@zcbenz
Copy link
Member

commented Aug 6, 2019

Backport of #17548 to 5-0-x.

notes: Fix the callback of beginFrameSubscription passing Buffer instead of NativeImage.

fix: the callback of beginFrameSubscription should pass NativeImage i…
…nstead of Buffer (#17548)

* Revert "revert: frame subscriber deprecation and re-enable tests"

This reverts commit f643ce4.

* fix: make sure SkBitmap's pixels are copied

@codebytere codebytere changed the title fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer (5-0-x) fix: the callback of beginFrameSubscription should pass NativeImage instead of Buffer Aug 6, 2019

@codebytere codebytere removed the new-pr 🌱 label Aug 6, 2019

@codebytere codebytere merged commit 5a8bdb2 into 5-0-x Aug 6, 2019

13 of 14 checks passed

electron-arm-testing Build #20190806.12 had test failures
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190806.12 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 6, 2019

Release Notes Persisted

Fix the callback of beginFrameSubscription passing Buffer instead of NativeImage.

@codebytere codebytere deleted the fix-frame-subscriber-5 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.