Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix dirtyChai spec failures #19652

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@codebytere
Copy link
Member

commented Aug 6, 2019

Fixes spec failures on master resultant of missing dirtyChai imports after TypeScript conversion.

import dirtyChai = require('dirty-chai')

instead of

import * as dirtyChai from 'dirty-chai'

is needed owing to this error if the proper syntax is used:

This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.

cc @MarshallOfSound @jkleinsc

Notes: none

@codebytere codebytere force-pushed the fix-specs-dirty-chai branch from b129bd4 to 4aa6de9 Aug 6, 2019

@codebytere codebytere requested review from MarshallOfSound and jkleinsc Aug 6, 2019

@codebytere codebytere requested a review from MarshallOfSound Aug 6, 2019

@codebytere codebytere changed the title spec: fix dirtyChai spec failures test fix dirtyChai spec failures Aug 6, 2019

@codebytere codebytere changed the title test fix dirtyChai spec failures test: fix dirtyChai spec failures Aug 6, 2019

@miniak

miniak approved these changes Aug 6, 2019

@codebytere codebytere merged commit da2401f into master Aug 6, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190806.18 succeeded
Details
electron-arm64-testing Build #20190806.18 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 6, 2019

No Release Notes

@codebytere codebytere deleted the fix-specs-dirty-chai branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.