Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on print cancellation and silent print settings #19668

Conversation

@trop
Copy link
Contributor

trop bot commented Aug 7, 2019

Backport of #19598

See that PR for details.

Notes: Fixed a crash on manual print cancellation as well as an issue with deviceName not working.

@trop trop bot requested a review from electron/wg-upgrades as a code owner Aug 7, 2019
@trop trop bot mentioned this pull request Aug 7, 2019
6 of 6 tasks complete
@trop trop bot added 7-0-x backport labels Aug 7, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Aug 7, 2019
Copy link
Member

codebytere left a comment

pending green ci

@codebytere codebytere merged commit ea9cfc1 into 7-0-x Aug 7, 2019
14 checks passed
14 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190807.8 succeeded
Details
electron-arm64-testing Build #20190807.9 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 7, 2019

Release Notes Persisted

Fixed a crash on manual print cancellation as well as an issue with deviceName not working.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-crash-on-print-cancellation-and-silent-print-settings-1565189263561 branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.