Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add property customization to save dialogs #19672

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@codebytere
Copy link
Member

commented Aug 7, 2019

Description of Change

This PR allows property customization on save dialogs in addition to what already exists for open dialogs. More specifically, this introduces the following properties on save dialogs:

  • showHiddenFiles - Show hidden files in dialog.
  • createDirectory macOS - Allow creating new directories from dialog.
  • treatPackageAsDirectory macOS - Treat packages, such as .app folders,
    as a directory instead of a file.
  • showOverwriteConfirmation Linux - Sets whether the user will be presented a confirmation dialog if the user types a file name that already exists.
  • dontAddToRecent Windows - Do not add the item being saved to the recent documents list.

In order to accomplish this, i separated the dialog property enums into those for SAVE and OPEN so that it is more clear which properties apply to which dialog subtypes.

cc @ckerr @miniak @zcbenz

Checklist

Release Notes

Notes: Added property customization to save dialogs.

@codebytere codebytere requested review from ckerr, miniak, deepak1556 and zcbenz Aug 7, 2019

@codebytere codebytere force-pushed the save-dialog-props branch from d51bbf8 to 5afc541 Aug 7, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Aug 8, 2019

@miniak

miniak approved these changes Aug 12, 2019

@zcbenz

zcbenz approved these changes Aug 13, 2019

@codebytere codebytere force-pushed the save-dialog-props branch from 5afc541 to be83539 Aug 13, 2019

@codebytere codebytere force-pushed the save-dialog-props branch from be83539 to cb6d42f Aug 13, 2019

@codebytere codebytere merged commit 28466a3 into master Aug 13, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190813.28 succeeded
Details
electron-arm64-testing Build #20190813.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 13, 2019

Release Notes Persisted

Added property customization to save dialogs.

@codebytere codebytere deleted the save-dialog-props branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.