Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "fix: activate the uv_loop on incoming IPC messages" #19727

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@zcbenz
Copy link
Member

commented Aug 13, 2019

Reverts #19449

It did not really fix #19368 and we have a real fix now.

Notes: no-notes

@codebytere codebytere changed the title chore: evert "fix: activate the uv_loop on incoming IPC messages" chore: revert "fix: activate the uv_loop on incoming IPC messages" Aug 13, 2019

@MarshallOfSound MarshallOfSound merged commit 49fe260 into master Aug 13, 2019

14 of 15 checks passed

Backportable? - 6-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Backportable? - 7-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190813.14 succeeded
Details
electron-arm64-testing Build #20190813.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 13, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the revert-19449-activate-on-ipc branch Aug 13, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

I have automatically backported this PR to "7-0-x", please check out #19737

@trop

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

A maintainer has manually backported this PR to "6-0-x", please check out #19739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.