Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in window.print() #19728

Merged

Conversation

@trop
Copy link
Contributor

trop bot commented Aug 13, 2019

Backport of #19690

See that PR for details.

Notes: Fixed a crash in window.print().

@trop trop bot requested a review from electron/wg-upgrades as a code owner Aug 13, 2019
@trop trop bot mentioned this pull request Aug 13, 2019
5 of 5 tasks complete
@trop trop bot added 7-0-x backport labels Aug 13, 2019
@codebytere codebytere force-pushed the trop/7-0-x-bp-fix-crash-in-window-print--1565678664987 branch from 7d474a0 to 788f46e Aug 13, 2019
@codebytere codebytere removed the new-pr 🌱 label Aug 13, 2019
@codebytere codebytere merged commit c1ad66b into 7-0-x Aug 13, 2019
14 checks passed
14 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190813.15 succeeded
Details
electron-arm64-testing Build #20190813.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 13, 2019

Release Notes Persisted

Fixed a crash in window.print().

@codebytere codebytere deleted the trop/7-0-x-bp-fix-crash-in-window-print--1565678664987 branch Aug 13, 2019
@vbennich

This comment has been minimized.

Copy link

vbennich commented Nov 12, 2019

Hi @codebytere I'm currently trying to contribute to this project in a university course and I am looking into what causes window.print() not to function twice in previous versions of Electron, mainly 5 and 6. Causing issues such as #20426 and #14705.

Is this the fix that fixes the problem? Because this issue seems to be solved in Electron 7 from the tests I've made. So would this be applicable to Electron 6? You seem the most knowledgable of this area so any input in where I might look would be very appreciative. Maybe this is a Chromium issue solved with a newer Chromium version but it would be great to fix this in previous Electron versions.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.