Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move net converter to gin #19734

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@DeerMichel
Copy link
Member

commented Aug 13, 2019

Description of Change

[Continuation of an endless PR series]

Follow-up from moving dialog API to gin. Replace gin adapter with whole converter and adapt to native_mate instead.

cc @zcbenz @deepak1556 @codebytere

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

@DeerMichel DeerMichel requested review from zcbenz and deepak1556 Aug 13, 2019

@zcbenz

zcbenz approved these changes Aug 14, 2019

@zcbenz zcbenz merged commit 4c54cfc into master Aug 14, 2019

12 of 13 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190813.21 succeeded
Details
electron-arm64-testing Build #20190813.20 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 14, 2019

No Release Notes

@zcbenz zcbenz deleted the ginc-net branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.