Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new nativeTheme API #19758

Merged

Conversation

@trop
Copy link
Contributor

trop bot commented Aug 14, 2019

Backport of #19656

See that PR for details.

Notes: Added new nativeTheme API to read and respond to changes in the OS's theme and color scheme

@trop trop bot referenced this pull request Aug 14, 2019
@trop trop bot added 7-0-x backport labels Aug 14, 2019

Returns `Boolean` - `true` if a high contrast theme is active, `false` otherwise.

**Depreacted:** Should use the new [`nativeTheme.shouldUseHighContrastColors`](native-theme.md#nativethemeshouldusehighcontrastcolors-macos-windows-readonly) API.

This comment has been minimized.

Copy link
@ckerr

ckerr Aug 14, 2019

Member

s/Depreacted/Deprecated

@ckerr ckerr dismissed their stale review Aug 14, 2019

As per verbal discussion, @MarshallOfSound will fix in master

@ckerr
ckerr approved these changes Aug 14, 2019
@codebytere codebytere merged commit d01a8ea into 7-0-x Aug 15, 2019
13 of 14 checks passed
13 of 14 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190814.27 succeeded
Details
electron-arm64-testing Build #20190814.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 15, 2019

Release Notes Persisted

Added new nativeTheme API to read and respond to changes in the OS's theme and color scheme

@codebytere codebytere deleted the trop/7-0-x-bp-feat-add-new-nativetheme-api-1565815397494 branch Aug 15, 2019
@tyler-ball tyler-ball referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.