Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure child_process.fork() doesn't modify main process env #19845

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@codebytere
Copy link
Member

commented Aug 20, 2019

Backport of #19742

See that PR for details.

Notes: Fixed an issue where a call to child_process.fork() would set ELECTRON_RUN_AS_NODE in the main process.

@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Aug 20, 2019

@trop trop bot referenced this pull request Aug 20, 2019
4 of 4 tasks complete

@codebytere codebytere requested a review from electron/wg-releases Aug 20, 2019

@ckerr
ckerr approved these changes Aug 20, 2019
@codebytere

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

not ok 750 session module ses.protocol handles requests from partition
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects\src\electron\spec\api-session-spec.js)
      at Test.Runnable._timeoutError (C:\projects\src\electron\spec\node_modules\mocha\lib\runnable.js:440:10)
      at C:\projects\src\electron\spec\node_modules\mocha\lib\runnable.js:251:24

is a known flake.

@zcbenz
zcbenz approved these changes Aug 23, 2019
@zcbenz

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

This requires approval from @electron/wg-upgrades.

@MarshallOfSound MarshallOfSound merged commit 5e33a5e into 6-0-x Aug 23, 2019

13 of 14 checks passed

appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190820.15 succeeded
Details
electron-arm64-testing Build #20190820.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 23, 2019

Release Notes Persisted

Fixed an issue where a call to child_process.fork() would set ELECTRON_RUN_AS_NODE in the main process.

@MarshallOfSound MarshallOfSound deleted the env-fresh-6 branch Aug 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.