Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openbsd support in the node module #19860

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@rnagy
Copy link
Contributor

commented Aug 21, 2019

Description of Change

The following simple change adds support for running electron
on OpenBSD.

Checklist

  • [X ] npm test passes
  • [X ] PR title follows semantic [commit guidelines]

Release Notes

Notes: no-notes

@rnagy rnagy requested a review from electron/wg-releases as a code owner Aug 21, 2019
@welcome

This comment has been minimized.

Copy link

commented Aug 21, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@ckerr
ckerr approved these changes Aug 21, 2019
Copy link
Member

left a comment

Thanks!

@electron-cation electron-cation bot removed the new-pr 🌱 label Aug 22, 2019
@codebytere codebytere merged commit 1f43af5 into electron:master Aug 22, 2019
9 checks passed
9 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@welcome

This comment has been minimized.

Copy link

commented Aug 22, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk

This comment has been minimized.

Copy link

commented Aug 22, 2019

No Release Notes

@rnagy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2019

Should I also create a pull requests for the 6-0-x branch to get it up to npmjs.com?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.