Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust window size in NCCALCSIZE instead of adding insets #19944

Merged
merged 1 commit into from Aug 26, 2019

Conversation

@brenca
Copy link
Member

commented Aug 26, 2019

Backport of #19883

See that PR for details.

Notes: Fixed a bug where sometimes a ~10px white border would be added to fullscreen windows on Windows.

@brenca brenca requested review from zcbenz and MarshallOfSound Aug 26, 2019

@trop trop bot referenced this pull request Aug 26, 2019
4 of 4 tasks complete

@codebytere codebytere merged commit 64026de into 6-0-x Aug 26, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190826.12 succeeded
Details
electron-arm64-testing Build #20190826.13 had test failures
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 26, 2019

Release Notes Persisted

Fixed a bug where sometimes a ~10px white border would be added to fullscreen windows on Windows.

@codebytere codebytere deleted the brenca/frameless-window-insets-fix-6-0-x branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.