Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that reloads retain modified window background colors #19973

Conversation

@trop
Copy link
Contributor

commented Aug 27, 2019

Backport of #19967

See that PR for details.

Notes: Fixed issue where reloading the window after calling setBackgroundColor would result in using an older background color setting.

@electron-cation electron-cation bot removed the new-pr 🌱 label Aug 27, 2019

@codebytere codebytere merged commit a5ed8fb into 6-0-x Aug 27, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190827.11 succeeded
Details
electron-arm64-testing Build #20190827.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 27, 2019

Release Notes Persisted

Fixed issue where reloading the window after calling setBackgroundColor would result in using an older background color setting.

@codebytere codebytere deleted the trop/6-0-x-bp-fix-ensure-that-reloads-retain-modified-window-background-colors-1566886479823 branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.