Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle WM_GETMINMAXINFO instead of letting chromium do it #20001

Merged
merged 1 commit into from Aug 28, 2019

Conversation

@brenca
Copy link
Member

commented Aug 28, 2019

Backport of #19928

See that PR for details.

Notes: Fixed a bug where windows would sometimes shrink to 0 size after being restored on Windows.

fix: handle WM_GETMINMAXINFO instead of letting chromium do it (#19928)
* fix: remove WM_GETMINMAXINFO workaround since it's no longer needed

* fix: handle WM_GETMINMAXINFO ourselves

* fix: remove part of the chromium WM_GETMINMAXINFO handler
@ckerr
ckerr approved these changes Aug 28, 2019

@ckerr ckerr merged commit fb82bfa into 6-0-x Aug 28, 2019

14 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190828.14 succeeded
Details
electron-arm64-testing Build #20190828.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Aug 28, 2019

Release Notes Persisted

Fixed a bug where windows would sometimes shrink to 0 size after being restored on Windows.

@ckerr ckerr deleted the brenca/restore-after-minimize-6-0-x branch Aug 28, 2019

@whyboris

This comment has been minimized.

Copy link

commented Aug 30, 2019

Thank you @brenca 🙇 Confirming that this bugfix, just released with Electron 6.0.6 closes my issue: #19816 🙇

@whyboris whyboris referenced this pull request Aug 30, 2019
10 of 19 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.