Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gtk_init() was called twice in AtomBrowserMainParts #20012

Conversation

@trop
Copy link
Contributor

trop bot commented Aug 28, 2019

Backport of #19986

See that PR for details.

Notes: Fixed Linux console warning about gtk_disable_setlocale().

@trop trop bot referenced this pull request Aug 28, 2019
4 of 5 tasks complete
@trop trop bot added 7-0-x backport labels Aug 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Aug 28, 2019
@zcbenz
zcbenz approved these changes Aug 29, 2019
@zcbenz zcbenz merged commit 080c2c9 into 7-0-x Aug 29, 2019
14 checks passed
14 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190828.49 succeeded
Details
electron-arm64-testing Build #20190828.47 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Aug 29, 2019

Release Notes Persisted

Fixed Linux console warning about gtk_disable_setlocale().

@zcbenz zcbenz deleted the trop/7-0-x-bp-fix-gtk_init-was-called-twice-in-atombrowsermainparts-1567013781498 branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.