Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip chrome_sandbox executable #20081

Conversation

@trop
Copy link
Contributor

commented Sep 3, 2019

Backport of #20049

See that PR for details.

Notes: Reduced the size of the chrome-sandbox binary on Linux from ~5MB to ~0.2MB by stripping debug symbols that were inadvertently being included.

@trop trop bot referenced this pull request Sep 3, 2019
3 of 6 tasks complete

@trop trop bot added 6-0-x backport labels Sep 3, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 3, 2019

@nornagon nornagon merged commit 97798a4 into 6-0-x Sep 3, 2019

13 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190903.6 succeeded
Details
electron-arm64-testing Build #20190903.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 3, 2019

Release Notes Persisted

Reduced the size of the chrome-sandbox binary on Linux from ~5MB to ~0.2MB by stripping debug symbols that were inadvertently being included.

@nornagon nornagon deleted the trop/6-0-x-bp-fix-strip-chrome_sandbox-executable-1567495063611 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.