Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash with --inspect-brk when running under ELECTRON_RUN_AS_NODE #20098

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@deepak1556
Copy link
Member

commented Sep 3, 2019

Description of Change

Fixes #19316

Backports from #19403

Checklist

Release Notes

Notes: fix crash with --inspect-brk under ELECTRON_RUN_AS_NODE flag

MarshallOfSound and others added 3 commits Jul 23, 2019
fix: ensure we wait for the inspect to disconnect
This re-orders our node clean up so that we free the environment before
the task runner is cleaned up as node uses the task runner during clean
up.  It also calls WaitForDisconnect() to ensure that inspector agents
are notified that the context is going down.
@deepak1556

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Failing test has been flaking on this branch for sometime now, merging.

@deepak1556 deepak1556 merged commit 4662ab9 into 6-0-x Sep 4, 2019

13 of 14 checks passed

appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190903.36 succeeded
Details
electron-arm64-testing Build #20190903.36 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 4, 2019

Release Notes Persisted

fix crash with --inspect-brk under ELECTRON_RUN_AS_NODE flag

@deepak1556 deepak1556 deleted the fix_inspector_brk_6_x branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.