Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure document.visibilityState aligns with the visibility of the TopLevelWindow #20134

Conversation

@trop
Copy link
Contributor

trop bot commented Sep 5, 2019

Backport of #19988

See that PR for details.

Notes: Fixed several cases where document.visibilityState would be incorrect. The win.show() and win.hide() methods now correctly update visibility state

@codebytere codebytere merged commit d25e511 into 7-0-x Sep 5, 2019
16 checks passed
16 checks passed
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190905.19 succeeded
Details
electron-arm64-testing Build #20190905.20 succeeded
Details
electron-woa-testing Build #20190905.8 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 5, 2019

Release Notes Persisted

Fixed several cases where document.visibilityState would be incorrect. The win.show() and win.hide() methods now correctly update visibility state

@codebytere codebytere deleted the trop/7-0-x-bp-fix-ensure-document-visibilitystate-aligns-with-the-visibility-of-the-toplevelwindow-1567706179862 branch Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.