Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: handle arm64 node headers #20194

Merged

Conversation

@trop
Copy link
Contributor

commented Sep 10, 2019

Backport of #20192

See that PR for details.

Notes: Fix node.lib linking issue

@trop trop bot referenced this pull request Sep 10, 2019
3 of 3 tasks complete
@trop trop bot added 6-0-x backport labels Sep 10, 2019
@codebytere codebytere merged commit 17b8b55 into 6-0-x Sep 11, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190910.9 succeeded
Details
electron-arm64-testing Build #20190910.10 succeeded
Details
electron-woa-testing Build #20190910.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 11, 2019

Release Notes Persisted

Fix node.lib linking issue

@codebytere codebytere deleted the trop/6-0-x-bp-build-handle-arm64-node-headers-1568150111231 branch Sep 11, 2019
@electron electron deleted a comment from yuna1256 Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.