Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add WOA node headers to checksum file #20255

Merged
merged 1 commit into from Sep 17, 2019
Merged

Conversation

@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Sep 17, 2019

Description of Change

#20192 added support for Windows on Arm node headers but it didn't add those files to the checksums file. This PR adds those files to the generated checksum file

Checklist

Release Notes

Notes: Added Windows on Arm node header files to checksum file.

@jkleinsc jkleinsc requested a review from as a code owner Sep 17, 2019
@jkleinsc
Copy link
Contributor Author

@jkleinsc jkleinsc commented Sep 17, 2019

Merging as CI failure unrelated to change.

Loading

@jkleinsc jkleinsc merged commit 42999f4 into master Sep 17, 2019
16 of 17 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Sep 17, 2019

Release Notes Persisted

Added Windows on Arm node header files to checksum file.

Loading

@trop
Copy link
Contributor

@trop trop bot commented Sep 17, 2019

I have automatically backported this PR to "6-0-x", please check out #20260

Loading

@trop
Copy link
Contributor

@trop trop bot commented Sep 17, 2019

I have automatically backported this PR to "7-0-x", please check out #20261

Loading

@codebytere codebytere deleted the add-woa-node-checksum branch Sep 17, 2019
@sofianguy sofianguy added this to Fixed for 6.0.10 in 6.1.x Sep 19, 2019
@sofianguy sofianguy added this to Fixed in 7.0.0-beta.5 in 7.2.x Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
6.1.x
Fixed for 6.0.10
7.2.x
Fixed in 7.0.0-beta.5
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants