Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add WOA node headers to checksum file #20261

Conversation

@trop
Copy link
Contributor

trop bot commented Sep 17, 2019

Backport of #20255

See that PR for details.

Notes: Added Windows on Arm node header files to checksum file.

@trop trop bot requested a review from electron/wg-releases as a code owner Sep 17, 2019
@trop trop bot mentioned this pull request Sep 17, 2019
3 of 3 tasks complete
@trop trop bot added 7-0-x backport labels Sep 17, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Sep 18, 2019

Merging as CI failures unrelated to PR.

@jkleinsc jkleinsc merged commit 51ffe25 into 7-0-x Sep 18, 2019
13 of 16 checks passed
13 of 16 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
build-mac Workflow: build-mac
Details
electron-woa-testing Build #20190917.14 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190917.13 succeeded
Details
electron-arm64-testing Build #20190917.13 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 18, 2019

Release Notes Persisted

Added Windows on Arm node header files to checksum file.

@jkleinsc jkleinsc deleted the trop/7-0-x-bp-build-add-woa-node-headers-to-checksum-file-1568738329050 branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.