Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct 'Entire screen' to 'Entire Screen' #20276

Merged
merged 1 commit into from Sep 20, 2019

Conversation

@codebytere
Copy link
Member

commented Sep 18, 2019

Description of Change

Close #20267.

Correct capitalization of 'Entire Screen'.

cc @jkleinsc @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 19, 2019
@codebytere codebytere force-pushed the fix-string-case branch from 1ce51db to 569b1d9 Sep 19, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

Merging as CI failures are unrelated to change.

@jkleinsc jkleinsc merged commit ae6f08d into master Sep 20, 2019
16 of 18 checks passed
16 of 18 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
electron-arm64-testing Build #20190919.27 had test failures
Details
Artifact Comparison No Changes
Details
Backportable? - 5-0-x Clean Backport
Details
Backportable? - 6-0-x Clean Backport
Details
Backportable? - 7-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190919.27 succeeded
Details
electron-woa-testing Build #20190919.21 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 20, 2019

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

I have automatically backported this PR to "5-0-x", please check out #20300

@trop

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

I have automatically backported this PR to "6-0-x", please check out #20301

@trop

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2019

I have automatically backported this PR to "7-0-x", please check out #20302

@jkleinsc jkleinsc deleted the fix-string-case branch Sep 20, 2019
@trop trop bot removed the in-flight/5-0-x label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.