Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: free screen capturers after usage ends #20280

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@codebytere
Copy link
Member

codebytere commented Sep 18, 2019

Description of Change

Backport of #20156.

See that PR for more details.

cc @electron/wg-releases

Checklist

Release Notes

Notes: Fixed desktopCapturer leak.

@codebytere codebytere requested a review from electron/wg-releases Sep 18, 2019
@codebytere codebytere requested a review from electron/wg-upgrades as a code owner Sep 18, 2019
@trop trop bot referenced this pull request Sep 18, 2019
4 of 4 tasks complete
@codebytere codebytere changed the title Backport desktop capture free fix: free screen capturers after usage ends Sep 18, 2019
@electron electron deleted a comment from DuplicatePR-bot Sep 20, 2019
@zcbenz
zcbenz approved these changes Sep 25, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Sep 25, 2019

Merging as CI failure unrelated to PR change

@jkleinsc jkleinsc merged commit 325bdfa into 7-0-x Sep 25, 2019
15 of 16 checks passed
15 of 16 checks passed
electron-woa-testing Build #20190919.2 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190918.40 succeeded
Details
electron-arm64-testing Build #20190918.40 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Sep 25, 2019

Release Notes Persisted

Fixed desktopCapturer leak.

@jkleinsc jkleinsc deleted the backport-desktop-capture-free branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.