Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable native unittesting #20293

Merged
merged 7 commits into from Oct 3, 2019

Conversation

@codebytere
Copy link
Member

commented Sep 20, 2019

Description of Change

This PR enables native unittesting of Electron's C++/ObjC++ code.

cc @ckerr @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere added the wip label Sep 20, 2019
@codebytere codebytere force-pushed the google-native-unittest branch 3 times, most recently from 10f9639 to 9b0f4d3 Sep 20, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 21, 2019
@codebytere codebytere force-pushed the google-native-unittest branch 3 times, most recently from 53654df to 85aec90 Sep 23, 2019
@codebytere codebytere removed the wip label Sep 23, 2019
@codebytere codebytere marked this pull request as ready for review Sep 23, 2019
@codebytere codebytere force-pushed the google-native-unittest branch 5 times, most recently from 29fbc48 to 3f193b4 Sep 24, 2019
Copy link
Member

left a comment

nice! a few nits.

BUILD.gn Outdated Show resolved Hide resolved
BUILD.gn Outdated Show resolved Hide resolved
script/spec-runner.js Outdated Show resolved Hide resolved
script/spec-runner.js Outdated Show resolved Hide resolved
script/spec-runner.js Outdated Show resolved Hide resolved
vsts-arm-test-steps.yml Show resolved Hide resolved
@codebytere codebytere force-pushed the google-native-unittest branch 2 times, most recently from 74521c5 to 3a2e48f Sep 27, 2019
@codebytere codebytere requested a review from nornagon Sep 27, 2019
@codebytere codebytere force-pushed the google-native-unittest branch from 3a2e48f to 0eba360 Sep 28, 2019
@codebytere codebytere force-pushed the google-native-unittest branch from 0eba360 to 0ee351e Oct 1, 2019
@miniak
miniak approved these changes Oct 2, 2019
@codebytere codebytere merged commit 80af35e into master Oct 3, 2019
14 of 15 checks passed
14 of 15 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191001.19 succeeded
Details
electron-arm64-testing Build #20191001.19 succeeded
Details
electron-woa-testing Build #20191001.15 had test failures
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 3, 2019

No Release Notes

@codebytere codebytere deleted the google-native-unittest branch Oct 3, 2019
erickzhao added a commit to erickzhao/electron that referenced this pull request Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.