Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert some more remote stuff to typescript #20324

Merged
merged 6 commits into from Sep 30, 2019

Conversation

@nornagon
Copy link
Member

commented Sep 23, 2019

Description of Change

This converts the browser side of the remote module to TypeScript.

Checklist

Release Notes

Notes: none

lib/browser/remote/objects-registry.ts Outdated Show resolved Hide resolved
lib/browser/remote/objects-registry.ts Outdated Show resolved Hide resolved
lib/browser/remote/objects-registry.ts Outdated Show resolved Hide resolved
lib/browser/remote/objects-registry.ts Outdated Show resolved Hide resolved
lib/browser/remote/objects-registry.ts Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 24, 2019
nornagon and others added 4 commits Sep 25, 2019
Co-Authored-By: Samuel Attard <sattard@slack-corp.com>
const isRemoteModuleEnabledImpl = function (contents) {
const webPreferences = contents.getLastWebPreferences() || {}
const isRemoteModuleEnabledImpl = function (contents: electron.WebContents) {
const webPreferences = (contents as any).getLastWebPreferences() || {}

This comment has been minimized.

Copy link
@miniak

miniak Sep 29, 2019

Contributor

Why do you need to cast to any here?

This comment has been minimized.

Copy link
@nornagon

nornagon Sep 29, 2019

Author Member

bc getLastWebPreferences isn't in the typings. i guess i could put it there? but i'm lazy :D

@miniak
miniak approved these changes Sep 29, 2019
@nornagon nornagon merged commit b7b0992 into master Sep 30, 2019
14 of 15 checks passed
14 of 15 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190925.20 succeeded
Details
electron-arm64-testing Build #20190925.20 succeeded
Details
electron-woa-testing Build #20190925.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Sep 30, 2019

No Release Notes

@nornagon nornagon deleted the ts-remote branch Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.