Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when building with enable_plugins=false #20354

Merged

Conversation

@miniak
Copy link
Contributor

commented Sep 27, 2019

Description of Change

Fix building with enable_plugins=false

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak requested review from deepak1556 and zcbenz Sep 27, 2019
@miniak miniak self-assigned this Sep 27, 2019
@miniak miniak marked this pull request as ready for review Sep 27, 2019
@miniak miniak added the wip label Sep 27, 2019
@miniak miniak force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from ca61fd7 to 996318a Sep 28, 2019
@miniak miniak requested a review from electron/wg-upgrades as a code owner Sep 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Sep 28, 2019
@zcbenz
zcbenz approved these changes Sep 30, 2019
@miniak miniak force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from 996318a to 08da944 Oct 1, 2019
@miniak miniak removed their assignment Oct 2, 2019
@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

@nornagon do you want us to upstream the Chromium patch before merging this PR?

@miniak miniak requested a review from nornagon Oct 7, 2019
@deepak1556

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Have updated the patches from upstream. Should be good to go once build is finished.

@deepak1556 deepak1556 force-pushed the miburda/fix_when_building_with_enable_plugins_false branch from 9f77022 to 3951a04 Oct 8, 2019
@deepak1556 deepak1556 removed their request for review Oct 8, 2019
@codebytere codebytere merged commit bb2ab01 into master Oct 9, 2019
15 of 17 checks passed
15 of 17 checks passed
Backportable? - 6-0-x Backport Failed
Details
Backportable? - 7-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191008.27 succeeded
Details
electron-arm64-testing Build #20191009.1 succeeded
Details
electron-woa-testing Build #20191008.22 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 9, 2019

No Release Notes

@codebytere codebytere deleted the miburda/fix_when_building_with_enable_plugins_false branch Oct 9, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/6-0-x and removed target/6-0-x labels Oct 9, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/7-0-x and removed target/7-0-x labels Oct 9, 2019
miniak added a commit that referenced this pull request Oct 9, 2019
miniak added a commit that referenced this pull request Oct 9, 2019
miniak added a commit that referenced this pull request Oct 9, 2019
miniak added a commit that referenced this pull request Oct 9, 2019
@miniak miniak referenced this pull request Oct 9, 2019
3 of 3 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@miniak has manually backported this PR to "7-0-x", please check out #20507

@trop trop bot added in-flight/7-0-x and removed needs-manual-bp/7-0-x labels Oct 9, 2019
@miniak miniak referenced this pull request Oct 9, 2019
3 of 3 tasks complete
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@miniak has manually backported this PR to "6-0-x", please check out #20508

@trop trop bot added in-flight/6-0-x and removed needs-manual-bp/6-0-x labels Oct 9, 2019
miniak added a commit that referenced this pull request Oct 9, 2019
@trop trop bot added merged/7-0-x and removed in-flight/7-0-x labels Oct 10, 2019
codebytere added a commit that referenced this pull request Oct 10, 2019
@trop trop bot added merged/6-0-x and removed in-flight/6-0-x labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.