Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move module tests to main process #20419

Merged
merged 3 commits into from Oct 9, 2019

Conversation

@nornagon
Copy link
Member

commented Oct 4, 2019

Description of Change

Moves module tests to the main process.

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from MarshallOfSound Oct 4, 2019
@miniak
miniak approved these changes Oct 4, 2019
Copy link
Contributor

left a comment

WOA failure is a legitimate failure

@nornagon

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

@jkleinsc something's weird about that test run. It looks like ELECTRON_SKIP_NATIVE_MODULE_TESTS is set somehow? but i don't see that anywhere in azure-pipelines-woa.yml.

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2019

@nornagon it could be set on the job definition on Azure Pipelines

@nornagon

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

@jkleinsc if that's the case can you move it to the yml file? it's v. confusing and hard to track down configuration that's not in the repo.

@nornagon

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

win-x64-testing has flaked 3 times in a row, so i'm giving up on it now. woa is fixed though :)

@nornagon nornagon requested a review from jkleinsc Oct 9, 2019
@nornagon nornagon dismissed jkleinsc’s stale review Oct 9, 2019

outdated

@nornagon nornagon merged commit 8de925c into master Oct 9, 2019
14 of 15 checks passed
14 of 15 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191009.24 had test failures
Details
electron-arm64-testing Build #20191009.25 succeeded
Details
electron-woa-testing Build #20191009.17 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 9, 2019

No Release Notes

@nornagon

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2019

merging as @jkleinsc's concern was addressed.

@nornagon nornagon deleted the move-module-tests branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.