Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support fitToPageEnabled and scaleFactor #20436

Merged
merged 2 commits into from Oct 18, 2019
Merged

Conversation

@Alecyrus
Copy link
Contributor

@Alecyrus Alecyrus commented Oct 5, 2019

Description of Change

Support fitToPageEnabled and scaleFactor in WebContents.printToPDF(), fix #20435

Checklist

Release Notes

notes: Added the support of fitToPageEnabled and scaleFactor in WebContents.printToPDF()

Support fitToPageEnabled and scaleFactor in  `WebContents.printToPDF()`
@welcome
Copy link

@welcome welcome bot commented Oct 5, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Loading

@jkleinsc jkleinsc requested a review from codebytere Oct 8, 2019
zcbenz
zcbenz approved these changes Oct 18, 2019
@zcbenz zcbenz merged commit 825e671 into electron:master Oct 18, 2019
7 of 9 checks passed
Loading
@welcome
Copy link

@welcome welcome bot commented Oct 18, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Loading

@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 18, 2019

Release Notes Persisted

Added the support of fitToPageEnabled and scaleFactor in WebContents.printToPDF()

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants