Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Asynchronous Messages Fiddle example #20441

Merged
merged 3 commits into from Oct 10, 2019

Conversation

@erickzhao
Copy link
Member

commented Oct 5, 2019

Description of Change

Refs #20442

Adds the Asynchronous Messages example from electron-api-demos into a runnable Fiddle example.

Gist link to Fiddle (same as code submitted in this PR): https://gist.github.com/fc7c008c2a1a8b3140c87c7fb4b5ef1c

Checklist

Release Notes

Notes: no-notes

@erickzhao erickzhao marked this pull request as ready for review Oct 5, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 6, 2019
Copy link
Contributor

left a comment

Overall LGTM, just a couple small nits

…/main.js

Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
…/index.html

Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
@jkleinsc jkleinsc merged commit c2e77e4 into electron:master Oct 10, 2019
8 of 9 checks passed
8 of 9 checks passed
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 10, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.