Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve TouchBarButton/TouchBarLabel accessibility #20454

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Oct 6, 2019

Description of Change

Resolves #20443.

Add an optional accessibilityLabel property to TouchBarButtons and TouchBarLabels, such that when a button is created with a confusing or icon-only label, developers can pass a description to VoiceOver to describe its purpose.

After this change:

const spin = new TouchBarButton({
    label: '馃幇',
    accessibilityLabel: 'Carousel Spinner',
    backgroundColor: '#7851A9',
    click: () => { console.log('I did a spin!') }
})

would be read by VoiceOver as "Carousel Spinner, button".

cc @MarshallOfSound

Checklist

Release Notes

Notes: Improve TouchBarButton and TouchBarLabel a11y with accessibilityLabel property.

@codebytere codebytere force-pushed the accessible-touchbar branch from 9956823 to 924b609 Oct 6, 2019
@codebytere codebytere added the a11y label Oct 6, 2019
@codebytere codebytere force-pushed the accessible-touchbar branch from 924b609 to 2823e1d Oct 6, 2019
@codebytere codebytere changed the title feat: improve TouchBarButton accessibility feat: improve TouchBarButton/TouchBarLabel accessibility Oct 7, 2019
@codebytere codebytere force-pushed the accessible-touchbar branch 2 times, most recently from 0b0bfde to 89dc77a Oct 7, 2019
@codebytere codebytere force-pushed the accessible-touchbar branch from 89dc77a to 1c92085 Oct 7, 2019
miniak
miniak approved these changes Oct 7, 2019
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Oct 8, 2019

Merging as CI failures unrelated to PR changes

Loading

@jkleinsc jkleinsc merged commit c16a186 into master Oct 8, 2019
13 of 15 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 8, 2019

Release Notes Persisted

Improve TouchBarButton and TouchBarLabel a11y with accessibilityLabel property.

Loading

@bpasero
Copy link
Contributor

@bpasero bpasero commented Sep 1, 2020

@codebytere quick question: would it be easy to add this property also to TouchBarSegmentedControl?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants