Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the sccache name #20462

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@felixrieseberg
Copy link
Member

commented Oct 7, 2019

Description of Change

This PR updates the name of the sccache - both in our docs and on CircleCI if we're building from a fork.

@jkleinsc: Is that the right move?

Checklist

Release Notes

Notes: no-notes

@felixrieseberg felixrieseberg requested a review from jkleinsc Oct 7, 2019
Copy link
Contributor

left a comment

Lol I thought this looked familiar: I made a branch and forgot about it:
18f27c2

@ckerr
ckerr approved these changes Oct 7, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

Merging as CI failures are unrelated to PR change

@jkleinsc jkleinsc merged commit b3e7657 into master Oct 8, 2019
12 of 18 checks passed
12 of 18 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
appveyor: win-x64-testing AppVeyor build failed
Details
electron-arm64-testing Build #20191007.25 had test failures
Details
Backportable? - 5-0-x Backport Failed
Details
Backportable? - 6-0-x Backport Failed
Details
Backportable? - 7-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191007.25 succeeded
Details
electron-woa-testing Build #20191007.20 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 8, 2019

No Release Notes

@jkleinsc jkleinsc deleted the sscache-docs branch Oct 8, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/5-0-x and removed target/5-0-x labels Oct 8, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-0-x label Oct 8, 2019
@trop

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.