Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a dev doc describing the patch system #20489

Merged
merged 4 commits into from Oct 9, 2019

Conversation

@nornagon
Copy link
Member

commented Oct 8, 2019

Description of Change

This adds documentation for how we apply patches to upstream, including the git-import-patches and git-export-patches tool.

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: none

nornagon added 2 commits Oct 8, 2019
@nornagon nornagon requested a review from electron/wg-upgrades as a code owner Oct 8, 2019
Copy link
Member

left a comment

❤️

Minor lint failure. Thanks!

Copy link
Member

left a comment

@nornagon we should probably either remove or update the document on Node.js too; i see the Chromium one was remove in another PR but i think this supersedes both :)

Copy link
Contributor

left a comment

Overall LGTM, just some small nits

docs/development/patches.md Show resolved Hide resolved
docs/development/patches.md Show resolved Hide resolved
docs/development/patches.md Outdated Show resolved Hide resolved
@nornagon nornagon merged commit c75c3ef into master Oct 9, 2019
13 of 15 checks passed
13 of 15 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
build-mac Workflow: build-mac
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191009.9 succeeded
Details
electron-arm64-testing Build #20191009.10 succeeded
Details
electron-woa-testing Build #20191009.7 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Oct 9, 2019

No Release Notes

@nornagon nornagon deleted the dev-docs-patching branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.