Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append network switches to network service process #20546

Merged
merged 1 commit into from Oct 14, 2019
Merged

Conversation

@deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Oct 11, 2019

Description of Change

Forward switches related to privileged schemes in network service process, otherwise will lead to service crash <-> restart infinite loop. Gets rid of the error message VALIDATION_ERROR_DESERIALIZATION_FAILED we have been seeing since the service was enabled.

Thanks to @nornagon who helped with debugging this issue.

Fixes #20517

Checklist

Release Notes

Notes: fix memory leak when using protocol.registerSchemeAsPrivileged api

zcbenz
zcbenz approved these changes Oct 14, 2019
@deepak1556 deepak1556 merged commit 5c2c301 into master Oct 14, 2019
15 of 16 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 14, 2019

Release Notes Persisted

fix memory leak when using protocol.registerSchemeAsPrivileged api

Loading

@deepak1556 deepak1556 deleted the fix_nw_crash branch Oct 14, 2019
@trop
Copy link
Contributor

@trop trop bot commented Oct 14, 2019

I have automatically backported this PR to "7-0-x", please check out #20558

Loading

deepak1556 added a commit that referenced this issue Apr 1, 2020
…2867)

* fix: ensure standard schemes are registered in nw service process

Refs #20546

* chore: add test

* chore: apply suggestions from code review

Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>

Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
deepak1556 added a commit that referenced this issue Apr 1, 2020
…2917)

* fix: ensure standard schemes are registered in nw service process

Refs #20546

* chore: add test

* chore: apply suggestions from code review

Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>

Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
sentialx added a commit to sentialx/electron that referenced this issue Apr 7, 2020
…ectron#22867)

* fix: ensure standard schemes are registered in nw service process

Refs electron#20546

* chore: add test

* chore: apply suggestions from code review

Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>

Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants