Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add patch to node for native module size issue on windows #20614

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Oct 16, 2019

Description of Change

Fixes #18670

As part of https://github.com/nodejs/node/pull/25931 node_with_ltcg configuration was moved to
node.gyp which caused native modules size increase which were depending on
this configuration transitively https://github.com/nodejs/node/issues/29501 through common.gypi.

On a longer term to prevent these kinds of issue, nodejs/node-gyp#1118 should be addressed and will take sometime for me to address it. Landing this as a temporary patch.

Checklist

Release Notes

Notes: fix native modules size increase with VC++ and node 12 on windows

@deepak1556 deepak1556 requested review from miniak and electron/wg-upgrades Oct 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 17, 2019
@jkleinsc jkleinsc merged commit 58115c1 into master Oct 17, 2019
18 checks passed
18 checks passed
Backportable? - 5-0-x Backport Failed
Details
Backportable? - 6-0-x Backport Failed
Details
Backportable? - 7-0-x Backport Failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191016.22 succeeded
Details
electron-arm64-testing Build #20191016.22 succeeded
Details
electron-woa-testing Build #20191016.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 17, 2019

Release Notes Persisted

fix native modules size increase with VC++ and node 12 on windows

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 17, 2019

I was unable to backport this PR to "6-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-1-x label Oct 17, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 17, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/6-0-x and removed target/5-0-x labels Oct 17, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 17, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@deepak1556 deepak1556 deleted the robo/fix_nm_size branch Oct 17, 2019
@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Oct 17, 2019

Will create manual backports by EOD.

deepak1556 added a commit that referenced this pull request Oct 18, 2019
deepak1556 added a commit that referenced this pull request Oct 18, 2019
deepak1556 added a commit that referenced this pull request Oct 18, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "7-0-x", please check out #20626

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "6-0-x", please check out #20627

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 18, 2019

@deepak1556 has manually backported this PR to "5-0-x", please check out #20628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.