Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names #20629

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@deepak1556
Copy link
Member

deepak1556 commented Oct 18, 2019

Description of Change

Fixes #20588

Backports libuv/libuv#2375

This should be fixed in master with #20584 , hence only targeting release branches.

Checklist

Release Notes

Notes: fix fs.mkdir/mkdirSync hang with {recursive: true} for invalid names with node 12 on windows

@deepak1556 deepak1556 requested review from electron/wg-releases Oct 18, 2019
@trop trop bot added 7-0-x backport labels Oct 18, 2019
@deepak1556 deepak1556 removed the backport label Oct 18, 2019
@codebytere codebytere dismissed their stale review Oct 18, 2019

meant just to comment, whoops

@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Oct 18, 2019

The newly-added spec seems to be failing

@deepak1556

This comment has been minimized.

Copy link
Member Author

deepak1556 commented Oct 18, 2019

It should be a windows only spec, will fix it tomorrow. Thanks!

@deepak1556 deepak1556 force-pushed the robo/fix_uv_mkdir_7_x branch from 5e9f1f7 to 4ed42e5 Oct 21, 2019
@zcbenz
zcbenz approved these changes Oct 21, 2019
@miniak miniak changed the title fix: backport libuv patch for fs.mkdir/mkdirSync on invlaid names fix: backport libuv patch for fs.mkdir/mkdirSync on invalid names Oct 21, 2019
@trop trop bot added the backport label Oct 21, 2019
@deepak1556 deepak1556 requested a review from electron/wg-upgrades Oct 21, 2019
@jkleinsc jkleinsc merged commit 3b59f12 into 7-0-x Oct 21, 2019
18 checks passed
18 checks passed
Artifact Comparison No Changes
Details
Backportable? - 5-0-x Clean Backport
Details
Backportable? - 6-0-x Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191021.3 succeeded
Details
electron-arm64-testing Build #20191021.3 succeeded
Details
electron-woa-testing Build #20191021.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 21, 2019

Release Notes Persisted

fix fs.mkdir/mkdirSync hang with {recursive: true} for invalid names with node 12 on windows

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 21, 2019

I have automatically backported this PR to "5-0-x", please check out #20664

@trop trop bot removed the target/5-0-x label Oct 21, 2019
@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Oct 21, 2019

I have automatically backported this PR to "6-0-x", please check out #20665

@trop trop bot added the in-flight/5-0-x label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.