Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: capitalize first letter #20644

merged 1 commit into from Oct 21, 2019


Copy link

Arjitc12 commented Oct 19, 2019

Notes: Capitalize first letter.


This comment has been minimized.

Copy link

welcome bot commented Oct 19, 2019

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Oct 19, 2019
zcbenz approved these changes Oct 21, 2019
@zcbenz zcbenz changed the title Update docs: capitalize first letter Oct 21, 2019
miniak approved these changes Oct 21, 2019
@codebytere codebytere merged commit 620ac9c into electron:master Oct 21, 2019
9 checks passed
9 checks passed
Artifact Comparison No Changes
Semantic Pull Request ready to be squashed
WIP Ready for review
appveyor: win-ia32-testing-pr AppVeyor build succeeded
appveyor: win-x64-testing-pr AppVeyor build succeeded
build-linux Workflow: build-linux
build-mac Workflow: build-mac
lint Workflow: lint
release-notes Release notes found

This comment has been minimized.

Copy link

welcome bot commented Oct 21, 2019

Congrats on merging your first pull request! 🎉🎉🎉


This comment has been minimized.

Copy link

release-clerk bot commented Oct 21, 2019

Release Notes Persisted

Capitalize first letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.