Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use xib file to construct macOS Menu #20670

Conversation

@trop
Copy link
Contributor

trop bot commented Oct 21, 2019

Backport of #20615

See that PR for details.

Notes: Fixed a regression in the recentDocuments role on macOS.

@trop trop bot mentioned this pull request Oct 21, 2019
4 of 4 tasks complete
@trop trop bot added 7-0-x backport labels Oct 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 21, 2019
@zcbenz
zcbenz approved these changes Oct 22, 2019
@zcbenz zcbenz merged commit d417bbd into 7-0-x Oct 22, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191021.30 succeeded
Details
electron-arm64-testing Build #20191021.29 succeeded
Details
electron-woa-testing Build #20191021.21 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 22, 2019

Release Notes Persisted

Fixed a regression in the recentDocuments role on macOS.

@zcbenz zcbenz deleted the trop/7-0-x-bp-fix-use-xib-file-to-construct-macos-menu-1571692312643 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.