Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly cancel redirects when mode is 'error' #20686

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@nornagon
Copy link
Member

@nornagon nornagon commented Oct 22, 2019

Description of Change

Without this change, when the redirect mode is 'error' for a net request, an error is thrown but the request continues and follows the redirect.

Checklist

Release Notes

Notes: Fixed an issue where net requests with redirection mode 'error' could incorrectly follow a redirect.

Copy link
Member

@deepak1556 deepak1556 left a comment

👍

Loading

zcbenz
zcbenz approved these changes Oct 23, 2019
@zcbenz zcbenz merged commit 2abea22 into master Oct 23, 2019
15 checks passed
Loading
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 23, 2019

Release Notes Persisted

Fixed an issue where net requests with redirection mode 'error' could incorrectly follow a redirect.

Loading

@zcbenz zcbenz deleted the cancel-redirect-on-error branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants