Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly free remote objects (7-0-x) #20693

Merged
merged 2 commits into from Oct 23, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Oct 22, 2019

Backport of #20671. See that change for details.

Notes: Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@nornagon nornagon requested review from electron/wg-releases as code owners Oct 22, 2019
@trop trop bot referenced this pull request Oct 22, 2019
3 of 5 tasks complete
@trop trop bot added backport master labels Oct 22, 2019
@nornagon nornagon changed the base branch from master to 7-0-x Oct 22, 2019
@trop trop bot added the 7-0-x label Oct 22, 2019
@nornagon nornagon changed the title Backport/7 0 x/fix remote object freer fix: properly free remote objects (7-0-x) Oct 22, 2019
@nornagon nornagon force-pushed the backport/7-0-x/fix-remote-object-freer branch from 0eeda86 to e617a4e Oct 22, 2019
@nornagon nornagon merged commit e23030b into 7-0-x Oct 23, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191023.3 succeeded
Details
electron-arm64-testing Build #20191023.3 succeeded
Details
electron-woa-testing Build #20191023.15 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 23, 2019

Release Notes Persisted

Fixed an issue where objects referenced by remote could sometimes not be correctly freed.

@nornagon nornagon deleted the backport/7-0-x/fix-remote-object-freer branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.