Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build_bring_back_node_with_ltcg_configuration.patch #20708

Conversation

@trop
Copy link
Contributor

trop bot commented Oct 23, 2019

Backport of #20672

See that PR for details.

Notes: fix native module size increase on windows, follow up fix to #20614

@trop trop bot requested a review from electron/wg-upgrades as a code owner Oct 23, 2019
@trop trop bot added 7-0-x backport labels Oct 23, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 23, 2019
@deepak1556 deepak1556 merged commit 8516422 into 7-0-x Oct 24, 2019
15 of 16 checks passed
15 of 16 checks passed
electron-arm-testing Build #20191023.38 failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20191023.34 succeeded
Details
electron-woa-testing Build #20191023.23 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 24, 2019

Release Notes Persisted

fix native module size increase on windows, follow up fix to #20614

@deepak1556 deepak1556 deleted the trop/7-0-x-bp-chore-update-build_bring_back_node_with_ltcg_configuration-patch-1571860119713 branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.