Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send ELECTRON_BROWSER_CONTEXT_RELEASE asynchronously #20715

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Oct 23, 2019

Description of Change

Backport of #20632

Checklist

Release Notes

Notes: Fixed hang when closing a scriptable popup window using the remote module.

@miniak miniak self-assigned this Oct 23, 2019
@trop trop bot referenced this pull request Oct 23, 2019
5 of 5 tasks complete
@zcbenz
zcbenz approved these changes Oct 24, 2019
@zcbenz zcbenz merged commit 50822bc into 7-0-x Oct 24, 2019
15 of 16 checks passed
15 of 16 checks passed
Artifact Comparison
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191023.45 succeeded
Details
electron-arm64-testing Build #20191023.45 succeeded
Details
electron-woa-testing Build #20191023.32 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 24, 2019

Release Notes Persisted

Fixed hang when closing a scriptable popup window using the remote module.

@zcbenz zcbenz deleted the miniak/async-context-release-7-0-x branch Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.