Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Performance checklist #20757

Merged
merged 20 commits into from Oct 28, 2019

Conversation

@trop
Copy link
Contributor

trop bot commented Oct 26, 2019

Backport of #20230

See that PR for details.

Notes: Added a performance checklist

felixrieseberg and others added 20 commits Sep 13, 2019
Co-Authored-By: Charles Kerr <ckerr@github.com>
Co-Authored-By: Charles Kerr <ckerr@github.com>
Co-Authored-By: loc <andy@slack-corp.com>
Co-Authored-By: loc <andy@slack-corp.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
@trop trop bot mentioned this pull request Oct 26, 2019
4 of 4 tasks complete
@trop trop bot added 7-0-x backport labels Oct 26, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 26, 2019
@miniak
miniak approved these changes Oct 26, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Oct 28, 2019

Merging as PR failures are unrelated to doc change.

@jkleinsc jkleinsc merged commit 6b70f0e into 7-0-x Oct 28, 2019
13 of 16 checks passed
13 of 16 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
build-mac Workflow: build-mac
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191026.5 succeeded
Details
electron-arm64-testing Build #20191026.5 succeeded
Details
electron-woa-testing Build #20191026.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 28, 2019

Release Notes Persisted

Added a performance checklist

@jkleinsc jkleinsc deleted the trop/7-0-x-bp-docs-performance-checklist-1572090431684 branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.