Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: there is only --ci #20794

Merged
merged 6 commits into from Oct 30, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Oct 28, 2019

Description of Change

This removes the option to run the remote tests without --ci, i.e., the only option now is to run the tests the same as in CI.

The isCI variable was often used to disable tests running in CI, but leave them enabled when run locally. I claim that a test that doesn't run in CI might as well not exist. Further, no current tests in the spec/ directory rely on the variable.

Checklist

Release Notes

Notes: none

@nornagon nornagon requested a review from codebytere Oct 30, 2019
@@ -840,97 +840,4 @@ describe('Menu module', function () {
expect(Menu.getApplicationMenu()).to.be.null('application menu')
})
})

describe('menu accelerators', async () => {

This comment has been minimized.

Copy link
@codebytere

codebytere Oct 30, 2019

Member

can we note somewhere that we should try to test this on CI somehow

Copy link
Member

codebytere left a comment

lgtm but i'd like to note removed tests somewhere so that we don't totally forget about them 🤔

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Oct 30, 2019

Tracked here #20865

@nornagon nornagon merged commit 6781d5e into master Oct 30, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191029.50 succeeded
Details
electron-arm64-testing Build #20191029.49 succeeded
Details
electron-woa-testing Build #20191029.37 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 30, 2019

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.