Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent menu gc during popup #20808

Merged

Conversation

@trop
Copy link
Contributor

trop bot commented Oct 29, 2019

Backport of #20785

See that PR for details.

Notes: Fixed a crash in Menus related to menu.popup().

@zcbenz
zcbenz approved these changes Oct 29, 2019
@zcbenz zcbenz merged commit 6e32da3 into 7-0-x Oct 29, 2019
15 of 16 checks passed
15 of 16 checks passed
appveyor: win-x64-testing AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191029.21 succeeded
Details
electron-arm64-testing Build #20191029.21 succeeded
Details
electron-woa-testing Build #20191029.18 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 29, 2019

Release Notes Persisted

Fixed a crash in Menus related to menu.popup().

@zcbenz zcbenz deleted the trop/7-0-x-bp-fix-prevent-menu-gc-during-popup-1572322882292 branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.