Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass frameId to v8Util.setRemoteCallbackFreer() #20814

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@miniak
Copy link
Contributor

miniak commented Oct 29, 2019

Description of Change

Backport of #20732

Checklist

Release Notes

Notes: Fixed memory leaks caused by callbacks not being released when the remote module is used in sub-frames (<iframe> or scriptable popup).

@miniak miniak self-assigned this Oct 29, 2019
@trop trop bot referenced this pull request Oct 29, 2019
4 of 5 tasks complete
@zcbenz
zcbenz approved these changes Oct 30, 2019
@zcbenz zcbenz merged commit 725dac3 into 7-0-x Oct 30, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191029.34 succeeded
Details
electron-arm64-testing Build #20191029.34 succeeded
Details
electron-woa-testing Build #20191029.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 30, 2019

Release Notes Persisted

Fixed memory leaks caused by callbacks not being released when the remote module is used in sub-frames (<iframe> or scriptable popup).

@zcbenz zcbenz deleted the miniak/remote-callback-freer-7-0-x branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.