Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to f30828899e4cd7161f6dc6507023f (master) #20824

Merged
merged 36 commits into from Nov 5, 2019

Conversation

@electron-bot
Copy link
Collaborator

electron-bot commented Oct 29, 2019

Updating Chromium to f30828899e4cd7161f6dc6507023f (lkgr).

See all changes in f5b345dd470f14eef6e44732ccf23..f30828899e4cd7161f6dc6507023f

Notes: no-notes

@electron-bot electron-bot requested a review from electron/wg-upgrades as a code owner Oct 29, 2019
@electron-bot electron-bot changed the title chore: bump chromium to a8809a19189b9f54cee11d50cc512 (master) chore: bump chromium to e8a12132a10bb47be8382ad9756a7 (master) Oct 30, 2019
@electron-bot electron-bot changed the title chore: bump chromium to e8a12132a10bb47be8382ad9756a7 (master) chore: bump chromium to f30828899e4cd7161f6dc6507023f (master) Oct 30, 2019
@nornagon

This comment has been minimized.

Copy link
Member

nornagon commented Oct 31, 2019

cc @codebytere please take a look at the printing patch!

electron-bot and others added 24 commits Oct 29, 2019
compiles but prob doesn't work
@jkleinsc jkleinsc force-pushed the roller/chromium/master branch from b9f55fa to 6507624 Nov 5, 2019
jkleinsc added 3 commits Nov 5, 2019
@@ -77,6 +77,9 @@ env-debug-build: &env-debug-build
GN_CONFIG: //electron/build/args/debug.gn
SKIP_DIST_ZIP: '1'

env-mac-debug-build: &env-mac-debug-build
GN_EXTRA_ARGS: 'symbol_level = 0'

This comment has been minimized.

Copy link
@nornagon

nornagon Nov 5, 2019

Member

Add a comment about why we're setting this?

Copy link
Member

deepak1556 left a comment

LGTM, do we plan to fix the print stuff as follow up ? If so would be good to create a tracking issue.

// Tells the RenderFrame to switch the CSS to print media type, render every
// requested page, and then switch back the CSS to display media type.
- PrintRequestedPages();
+ PrintRequestedPages(bool silent);

This comment has been minimized.

Copy link
@deepak1556

deepak1556 Nov 5, 2019

Member

Should also patch for accepting the print setting we pass.

This comment has been minimized.

Copy link
@nornagon

nornagon Nov 5, 2019

Member

yeah, this is going to be a followup. according to @codebytere it's already broken in master, so this won't break it further. #17523 is the tracking issue.

@jkleinsc jkleinsc merged commit 9a198e8 into master Nov 5, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191105.31 succeeded
Details
electron-arm64-testing Build #20191105.30 succeeded
Details
electron-woa-testing Build #20191105.27 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 5, 2019

No Release Notes

@jkleinsc jkleinsc deleted the roller/chromium/master branch Nov 5, 2019
nornagon added a commit that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.