Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint spec-main #20835

Merged
merged 5 commits into from Nov 1, 2019

Conversation

@nornagon
Copy link
Member

nornagon commented Oct 29, 2019

Description of Change

We haven't been running eslint over spec-main. Now we are.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 30, 2019
@codebytere

This comment has been minimized.

Copy link
Member

codebytere commented Oct 31, 2019

@nornagon this needs a rebase but it looks fine otherwise so i'll 👍 when it's green!

.eslintrc.json Outdated Show resolved Hide resolved
nornagon and others added 2 commits Oct 31, 2019
@nornagon nornagon merged commit ecd9e1f into master Nov 1, 2019
15 checks passed
15 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191101.32 succeeded
Details
electron-arm64-testing Build #20191101.32 succeeded
Details
electron-woa-testing Build #20191101.22 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 1, 2019

No Release Notes

@nornagon

This comment has been minimized.

Copy link
Member Author

nornagon commented Nov 1, 2019

Thanks @jkleinsc !

@nornagon nornagon deleted the lint-spec-main branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.