Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable compositor recycling only for attached views (7-0-x) #20846

Merged

Conversation

@poiru
Copy link
Member

poiru commented Oct 30, 2019

Backport of #20829

Notes: Fix flicker when switching between BrowserViews

Backport of #20829

Notes: Fix flicker when switching between `BrowserView`s
@poiru poiru requested a review from electron/wg-upgrades as a code owner Oct 30, 2019
@trop trop bot added 7-0-x backport labels Oct 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 30, 2019
@jkleinsc

This comment has been minimized.

Copy link
Contributor

jkleinsc commented Oct 30, 2019

Merging as CI failures unrelated to PR change.

@jkleinsc jkleinsc merged commit 3841ac9 into electron:7-0-x Oct 30, 2019
8 of 10 checks passed
8 of 10 checks passed
Valid Backport Invalid Backport
Details
appveyor: win-x64-testing-pr AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 30, 2019

Release Notes Persisted

Fix flicker when switching between BrowserViews

@poiru poiru deleted the poiru:recycle-compositor-for-removed-views-7-0-x branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.