Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swapped labels on open/save gtkdialog #20882

Conversation

@trop
Copy link
Contributor

trop bot commented Oct 31, 2019

Backport of #20861

See that PR for details.

Notes: Fixed a label mismatch on open and save dialogs on GTK.

@trop trop bot referenced this pull request Oct 31, 2019
4 of 4 tasks complete
@trop trop bot added 7-0-x backport labels Oct 31, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 label Oct 31, 2019
@codebytere codebytere merged commit 1926169 into 7-0-x Oct 31, 2019
10 of 15 checks passed
10 of 15 checks passed
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20191031.29 failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-woa-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20191031.29 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Oct 31, 2019

Release Notes Persisted

Fixed a label mismatch on open and save dialogs on GTK.

@codebytere codebytere deleted the trop/7-0-x-bp-fix-swapped-labels-on-open-save-gtkdialog-1572533754814 branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.