Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable `strip_absolute_paths_from_debug_symbols` on debug.gn(ref #20775) #20884

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@ymmuse
Copy link
Contributor

ymmuse commented Oct 31, 2019

Description of Change

This PR is same as #20775, but it will merge into master branch. @jkleinsc

We can't set breakpoints directly in the Chromium source on XCode, Because from this commit it was set strip_absolute_paths_from_debug_symbols default to true. This PR make strip_absolute_paths_from_debug_symbols to false in debug/build.gn.

Checklist

Release Notes

Notes: Make strip_absolute_paths_from_debug_symbols to false in debug.gn

@zcbenz zcbenz force-pushed the ymmuse:build-debug branch from 6d7977a to eb7f040 Nov 27, 2019
@zcbenz
zcbenz approved these changes Nov 27, 2019
@zcbenz zcbenz merged commit 0618505 into electron:master Nov 28, 2019
9 of 11 checks passed
9 of 11 checks passed
appveyor: win-ia32-testing-pr AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Backportable? - 7-1-x Clean Backport
Details
Backportable? - 8-x-y Clean Backport
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@welcome

This comment has been minimized.

Copy link

welcome bot commented Nov 28, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 28, 2019

Release Notes Persisted

Make strip_absolute_paths_from_debug_symbols to false in debug.gn

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 28, 2019

I have automatically backported this PR to "8-x-y", please check out #21316

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Nov 28, 2019

I have automatically backported this PR to "7-1-x", please check out #21317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.