Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Unicode version of ShellExecute() in OpenExternalOnWorkerThread() #20905

Conversation

@trop
Copy link
Contributor

trop bot commented Nov 1, 2019

Backport of #20879

See that PR for details.

Notes: Fixed shell.openExternal() option workingDirectory not working with Unicode characters.

@jkleinsc jkleinsc merged commit e2c7e4b into 7-0-x Nov 1, 2019
16 checks passed
16 checks passed
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
Valid Backport Valid Backport
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20191101.6 succeeded
Details
electron-arm64-testing Build #20191101.6 succeeded
Details
electron-woa-testing Build #20191101.4 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Nov 1, 2019

Release Notes Persisted

Fixed shell.openExternal() option workingDirectory not working with Unicode characters.

@jkleinsc jkleinsc deleted the trop/7-0-x-bp-fix-use-unicode-version-of-shellexecute-in-openexternalonworkerthread--1572586748198 branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.